fix: new version of grpc causes lint issues #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c24t
approved these changes
May 14, 2020
lzchen
approved these changes
May 14, 2020
cnnradams
pushed a commit
to cnnradams/opentelemetry-python
that referenced
this pull request
May 15, 2020
…ented (open-telemetry#696) This addresses the linting problems caused by a newer version of grpc: ************ Module _interceptor ext/opentelemetry-ext-grpc/src/opentelemetry/ext/grpc/grpcext/_interceptor.py:167:0: W0223: Method '__enter__' is abstract in class 'Channel' but is not overridden (abstract-method) ext/opentelemetry-ext-grpc/src/opentelemetry/ext/grpc/grpcext/_interceptor.py:167:0: W0223: Method '__exit__' is abstract in class 'Channel' but is not overridden (abstract-method)
owais
pushed a commit
to owais/opentelemetry-python
that referenced
this pull request
May 22, 2020
…ented (open-telemetry#696) This addresses the linting problems caused by a newer version of grpc: ************ Module _interceptor ext/opentelemetry-ext-grpc/src/opentelemetry/ext/grpc/grpcext/_interceptor.py:167:0: W0223: Method '__enter__' is abstract in class 'Channel' but is not overridden (abstract-method) ext/opentelemetry-ext-grpc/src/opentelemetry/ext/grpc/grpcext/_interceptor.py:167:0: W0223: Method '__exit__' is abstract in class 'Channel' but is not overridden (abstract-method)
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
…ry#701) * feat: add jaeger http trace format (open-telemetry#696) * feat: add jaeger http trace format (open-telemetry#696) * feat: add jaeger http trace format (open-telemetry#696) * feat: add jaeger http trace format (open-telemetry#696) * feat: add jaeger http trace format (open-telemetry#696) * feat: add jaeger http trace format (open-telemetry#696) * fix: we should set sampled\unsampled via flag * fix: we should set sampled\unsampled via flag * fix: flags should be converted to hex, not decimal * feat: create new package for propagation jaeger * fix: remove unused dependencies, correct readme header, moved out jaeger from core index.ts * fix: added jaeger keyword * fix: remove comma * docs: replace NodeTracer with NodeTracerRegistry * fix: added missing jaeger keyword to exporter-jaeger * fix: remove test for browser * fix: remove yarn for browser * fix: use same naming style as other packages * feat: added index.ts and version.ts, revert test for browser * fix: tests added index-webpack.ts * test: add test with span generated by jaeger client * fix: apply review changes * fix: move out from sub dirs * docs: use common language for docs * fix: test script fix Co-authored-by: Uladzislau Kiva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the linting problems caused by a newer version of grpc: